-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER #2796
Closed
Explooosion-code
wants to merge
4
commits into
citizenfx:master
from
Explooosion-code:passenger-weight-natives
Closed
feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER #2796
Explooosion-code
wants to merge
4
commits into
citizenfx:master
from
Explooosion-code:passenger-weight-natives
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes, please |
github-actions
bot
added
the
invalid
Requires changes before it's considered valid and can be (re)triaged
label
Sep 17, 2024
Hi. Can you please rename natives to SET/GET_GLOBAL_PASSENGER_MASS_MULTIPLIER and also you need to reset it on disconnect from the server in OnKillNetwork to its default value. You can check how our custom natives work now. |
prikolium-cfx
added
triage
Needs a preliminary assessment to determine the urgency and required action
and removed
invalid
Requires changes before it's considered valid and can be (re)triaged
labels
Sep 19, 2024
Explooosion-code
changed the title
feat(extra-natives/five): implement [GET/SET]_PASSENGER_WEIGHT
feat(extra-natives/five): implement [GET/SET]_GLOBAL_PASSENGER_MASS_MULTIPLIER
Sep 19, 2024
github-actions
bot
added
invalid
Requires changes before it's considered valid and can be (re)triaged
triage
Needs a preliminary assessment to determine the urgency and required action
and removed
triage
Needs a preliminary assessment to determine the urgency and required action
invalid
Requires changes before it's considered valid and can be (re)triaged
labels
Sep 19, 2024
…OBAL_PASSENGER_MASS_MULTIPLIER tweak(native-docs): Add information aboud default value feat(extra-natives/five): Reset passenger mass OnKillNetwork tweak(extra-natives/five): Change native name PASSENGER_WEIGHT -> GLOBAL_PASSENGER_MASS_MULTIPLIER
Explooosion-code
force-pushed
the
passenger-weight-natives
branch
from
September 19, 2024 11:58
1ed957e
to
341dcc5
Compare
github-actions
bot
added
triage
Needs a preliminary assessment to determine the urgency and required action
invalid
Requires changes before it's considered valid and can be (re)triaged
and removed
invalid
Requires changes before it's considered valid and can be (re)triaged
triage
Needs a preliminary assessment to determine the urgency and required action
labels
Sep 19, 2024
prikolium-cfx
approved these changes
Sep 19, 2024
prikolium-cfx
added
ready-to-merge
This PR is enqueued for merging
and removed
invalid
Requires changes before it's considered valid and can be (re)triaged
labels
Sep 19, 2024
PsychoShock
reviewed
Sep 19, 2024
github-actions
bot
added
the
invalid
Requires changes before it's considered valid and can be (re)triaged
label
Sep 19, 2024
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
invalid
Requires changes before it's considered valid and can be (re)triaged
ready-to-merge
This PR is enqueued for merging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Adding a getter and setter to control the mass of passengers. I.E if you have a racing server you might want to have passengers not decrease performance of vehicle and you might want to
...
How is this PR achieving the goal
By setting/getting the value that GTA is using for decreasing performance of vehicle depending on passenger count
...
This PR applies to the following area(s)
Fivem, Extra Natives
...
Successfully tested on
Game builds: 1604, 2060, 2189, 3095, 3258
Platforms: Windows
Checklist